I'll start with the negatives and close with the many, many positives that massively outweigh them.
Negatives
The hotel in Casablanca is just plain bad. To make a first impression, it's a poor start. It's been mentioned in other reviews and was spoken about in my group, it's not nice. Rooms are small, outdated and looks like it's 20 years overdue for a change of carpet and bathrooms. It can't be hard to find somewhere better.
I appreciate Tinghir isn't on the tourist trail, so hotels are limited, but it wasn't the best hotel - particularly for single occupancy (it's a makeshift extension on a roof).
The activity of climbing, if cancelled, is replaced by cycling. More options could be offered, like walking, or just to relax with your group rather than feel pressured into a cycle activity for experienced/expert riders.
Some hotels change to what is advertised, depending on what's available, so don't pin your hopes on the advert.
Tipping: be more upfront. Yes, about tipping for your tour leader is on the ad/itinerary, but advising about tips for your driver and then the 350dh for included meals/visits needs to be made clear before arriving in Morocco so you can budget for it.
Positives
Everything else. It's absolutely epic! There is no way I could have seen and done all that was included on my own.
It's a stunning and beautiful country. Yes, some of the hotels could be better (definitely the two mentioned above that were poor) but they were fine for where you were.
Our team leader, Ismail, was brilliant, funny, considerate, knowledgeable and a bundle of energy. I couldn't have asked for a better group and leader for this tour.
The desert was simply beautiful, for sunset and sunrise. Something I'll never forget. I would've loved a chance to dune board, so maybe there's something to add, but I'm nitpicking (it's a bucket list activity).
Chefchaouen was very pretty and you'll figure out the quieter spots to get your photos but it does match what you're imagining. The walk up to the Spanish mosque for sunset is special.
While there are long drives, the stops along the way to connect with your group are what you cherish. Share and take photos of each other, joke around, talk and support one another. (I've made one photo book purely dedicated to this incredible group I was with).
The visits to families and fresh/home-cooked meals are gems. Yes, you'll joke about endless tagine but it's delicious, especially with mint tea. Constant statements of "this is my favourite meal"!
A few of the places you'll visit and want to buy from from - ceramics, rugs, oils - will take card or ship international, so you don't have to always worry about cash and bartering.
Everything about this trip exceeded expectations. It's a breathtaking country, full of beauty. Embrace it, enjoy it, book it.
I'd certainly return, especially for more time in Marrakech. A long weekend, perhaps, in autumn/winter or early spring.